Winds from planet forming discs can be photoevaporative or magnetically driven. Both types of wind can remove mass from the disc and affect the surface density evolution of the planet making material. A basic difference between these two types of wind is that magnetic winds, unlike photoevaporative winds can also remove angular momentum and thus drive accretion in the system. Indeed a departure from the classic alpha disc model is gaining momentum in the field and is one of the main topics of this workshop. Unfortunately, both photoevaporation and MHD numerical modes have yet to be observationally constrained and their relative contribution to the evolution of discs at various ages is still uncertain. In this contribution I will discuss currently observed disc wind diagnostics and present past and current efforts in modelling these lines using state-of-the-art theoretical models as well as analytical prescriptions.